Collection Repeat: Use root scope when checking for in-progress digest #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey mrwade, it's best if we can reliably reproduce a bug, but this seems pretty straight forward. @ajoslin what do you think? |
|
It seems like a reasonable change to me. @mrwade could you change it so that collectionRepeatDataSource injects $rootScope and use |
|
@ajoslin Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue using collection-repeat when a digest was in-progress. The in-progress digest was reflected on the root scope by checking
$$phase, but not when checking$$phaseon the child scope that collection-repeat was using. This was causing the ol' "digest already in progress" error.This pull request is to update collection-repeat to use the root scope when checking for an in-progress digest.
Note: I tried to recreate this bug in smaller codepen example that I could share but was unfortunately unable to do so. I am actually unsure of the exact conditions that cause this issue. :-/